internal: fix unused errors reported by ineffassign #610

linsite · 2025-12-10T04:07:58Z

Updates golang/go#35136

gopherbot · 2025-12-10T04:17:32Z

This PR (HEAD: 8819d3d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/728860.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-10T04:26:27Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-10T06:17:09Z

Message from Lin Lin:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-13T17:27:44Z

Message from Alan Donovan:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-15T00:35:01Z

This PR (HEAD: c1eaea2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/728860.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-15T00:50:35Z

Message from Lin Lin:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-15T02:22:50Z

Message from Carlo Alberto Ferraris:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-15T02:49:39Z

This PR (HEAD: 6252013) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/728860.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-15T03:05:38Z

Message from Lin Lin:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-15T03:21:49Z

Message from Alan Donovan:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

Updates #76704

gopherbot · 2025-12-15T03:40:33Z

This PR (HEAD: 77c16e6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/728860.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-12-15T03:48:23Z

Message from Alan Donovan:

Patch Set 5: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-15T06:21:00Z

Message from Lin Lin:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-15T16:21:45Z

Message from Madeline Kalil:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-18T04:00:04Z

Message from Lin Lin:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-18T10:39:08Z

Message from t hepudds:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-18T10:39:08Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-18T10:24:02Z","revision":"566936811357aa3767e4e0624b6449d2e9369fc0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-18T10:57:05Z

Message from t hepudds:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-18T10:57:06Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-12-18T10:57:07Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/728860.
After addressing review feedback, remember to publish your drafts!

Updates golang/go#35136 Change-Id: I6abc1ba02bbd1ea099f53cb95098080c5d180bf6 GitHub-Last-Rev: 77c16e6 GitHub-Pull-Request: #610 Reviewed-on: https://go-review.googlesource.com/c/tools/+/728860 Reviewed-by: Madeline Kalil <mkalil@google.com> Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>

gopherbot · 2025-12-18T13:00:39Z

This PR is being closed because golang.org/cl/728860 has been merged.

linsite force-pushed the master branch from 8819d3d to c1eaea2 Compare December 15, 2025 00:27

linsite force-pushed the master branch from c1eaea2 to 6252013 Compare December 15, 2025 02:44

internal: fix unused errors reported by ineffassign

77c16e6

Updates #76704

linsite force-pushed the master branch from 6252013 to 77c16e6 Compare December 15, 2025 03:39

gopherbot closed this Dec 18, 2025

internal: fix unused errors reported by ineffassign #610

internal: fix unused errors reported by ineffassign #610

Uh oh!

Conversation

linsite commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Dec 10, 2025

Uh oh!

gopherbot commented Dec 10, 2025

Uh oh!

gopherbot commented Dec 10, 2025

Uh oh!

gopherbot commented Dec 13, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 15, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

gopherbot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

linsite commented Dec 10, 2025 •

edited

Loading